[libvpl] New port [ffmpeg] switch qsv from mfx to vpl [fdk-aac] Fix android support#51419
[libvpl] New port [ffmpeg] switch qsv from mfx to vpl [fdk-aac] Fix android support#51419BillyONeal merged 10 commits intomicrosoft:masterfrom
Conversation
|
Sorry for the traffic, I was going to try to separate this out and run it in my local copies but somehow even though I did Since I already pushed here I'm just going to finish fixing it. |
BillyONeal
left a comment
There was a problem hiding this comment.
I observe that ffmpeg[all], ffmpeg[all-gpl], and ffmpeg[all-nonfree] are currently possible to "cascade" in ci.feature.baseline.txt which should not be possible; the whole purpose of those features appears to be to pick a configuration that is possible, at least for the known non-community triplets.
|
@BillyONeal Thanks for the fix |
|
Very odd, pkgconfig cannot find |
5913e8f to
7f0554b
Compare
|
OK since you have now pushed I'll go back to fixing the remaining bits in a PR against you. (I need to fix the consequences of removing the cascade lines for the "group features") |
|
@BillyONeal Thank you, |
|
Can we use |
fdca2fd to
74a5ec1
Compare
| ffmpeg[all](android | (linux & arm64))=feature-fails | ||
| ffmpeg[all-gpl](android | (linux & arm64))=feature-fails | ||
| ffmpeg[all-nonfree](android | (linux & arm64))=feature-fails | ||
| ffmpeg[all-nonfree](android)=cascade |
There was a problem hiding this comment.
| ffmpeg[all](android | (linux & arm64))=feature-fails | |
| ffmpeg[all-gpl](android | (linux & arm64))=feature-fails | |
| ffmpeg[all-nonfree](android | (linux & arm64))=feature-fails | |
| ffmpeg[all-nonfree](android)=cascade | |
| ffmpeg[all](android | (linux & arm64))=feature-fails | |
| ffmpeg[all-gpl](android | (linux & arm64))=feature-fails | |
| ffmpeg[all-nonfree](android | (linux & arm64))=feature-fails |
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:291:8: error: 'all-nonfree' was already declared as 'feature-fails'
on expression: ffmpeg[all-nonfree](android)=cascade
^
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:290:8: note: previous declaration was here
on expression: ffmpeg[all-nonfree](android | (linux & arm64))=feature-fails
^There was a problem hiding this comment.
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:290:8: error: ffmpeg[core,all-nonfree]:x64-android was unexpectedly a cascading failure because the following dependencies are unavailable: fdk-aac[he-aac]:x64-android only supports !android
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:290:8: note: consider changing this to =cascade instead
There was a problem hiding this comment.
fdk-aac[he-aac](android) now should work.
Co-authored-by: Derek Cyrus-Chow <7149253+dcyruschow-cat@users.noreply.github.com>
Fix ffmpeg[qsv] cascade declaration. Remove cascade declarations for ffmpeg meta-features.
…ib & Minimize patch
Co-authored-by: Billy O'Neal <bion@microsoft.com>
@BillyONeal @vicroms |
|
|
@BillyONeal This pr cannot be auto-merged. |
|
Yeah, build was still running when I set auto merge. I'm investigating in #51494 and will keep you posted. |
|
Confirmed, identical failure in "do nothing" change #51494 |
|
Ah crap, I missed that the "unrelated" change actually breaks one of the "-ci-" ports which has now caused all PRs to start failing :( |
|
Is there anything I can do to help? |
|
I missed that too, I'll submit a new pull request right away to fix it. |
./vcpkg x-add-version --alland committing the result.Based on #51196